Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add xcm benchmarks to shiden and astar #1206

Merged
merged 4 commits into from
Apr 4, 2024
Merged

feat: add xcm benchmarks to shiden and astar #1206

merged 4 commits into from
Apr 4, 2024

Conversation

ashutoshvarma
Copy link
Member

@ashutoshvarma ashutoshvarma commented Mar 27, 2024 •
edited
Loading

Pull Request Summary
This PR adds the existing xcm benchmarks to Astar and Shiden replacing the use for FixedInfoBounds with WeightInfoBounds in respective XCM Configs.

TODO

  • Run benchmarks and update the weights

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@ashutoshvarma ashutoshvarma added shiden related to shiden runtime astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. labels Mar 27, 2024
@ashutoshvarma
Copy link
Member Author

/bench shibuya-dev xcm_benchmarks_fungible,xcm_benchmarks_generic

@ashutoshvarma
Copy link
Member Author

/bench shiden-dev xcm_benchmarks_fungible,xcm_benchmarks_generic

@ashutoshvarma
Copy link
Member Author

/bench astar-dev xcm_benchmarks_fungible,xcm_benchmarks_generic

@github-actions GitHub Actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/8447391552.
Please wait for a while.
Branch: feat/xcm-benchamrks
SHA: ec89595

@github-actions GitHub Actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/8447391552.

@github-actions GitHub Actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/8447390862.
Please wait for a while.
Branch: feat/xcm-benchamrks
SHA: ec89595

@github-actions GitHub Actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/8447390862.

@github-actions GitHub Actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/8447392351.
Please wait for a while.
Branch: feat/xcm-benchamrks
SHA: ec89595

@github-actions GitHub Actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/8447392351.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/unified-accounts/src 85% 0% ✔
precompiles/dapps-staking/src 93% 0% ✔
pallets/astar-xcm-benchmarks/src 88% 0% ✔
pallets/astar-xcm-benchmarks/src/fungible 100% 0% ✔
pallets/dapps-staking/src 89% 0% ✔
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0% ❌
pallets/ethereum-checked/src 79% 0% ➖
pallets/static-price-provider/src 58% 0% ➖
pallets/dapp-staking-v3/src/benchmarking 99% 0% ✔
pallets/dapps-staking/src/pallet 86% 0% ✔
precompiles/dapp-staking-v3/src/test 0% 0% ❌
pallets/collator-selection/src 91% 0% ✔
precompiles/dapp-staking-v3/src 90% 0% ✔
precompiles/substrate-ecdsa/src 74% 0% ➖
precompiles/dispatch-lockdrop/src 86% 0% ✔
pallets/dapp-staking-migration/src 0% 0% ❌
precompiles/xcm/src 73% 0% ➖
precompiles/xvm/src 74% 0% ➖
primitives/src 29% 0% ❌
pallets/dynamic-evm-base-fee/src 92% 0% ✔
chain-extensions/types/assets/src 0% 0% ❌
primitives/src/xcm 65% 0% ➖
precompiles/assets-erc20/src 81% 0% ✔
primitives/src/migrations 0% 0% ❌
pallets/block-rewards-hybrid/src 91% 0% ✔
chain-extensions/xvm/src 0% 0% ❌
chain-extensions/types/unified-accounts/src 0% 0% ❌
precompiles/unified-accounts/src 100% 0% ✔
chain-extensions/pallet-assets/src 56% 0% ➖
pallets/xvm/src 51% 0% ➖
chain-extensions/unified-accounts/src 0% 0% ❌
pallets/inflation/src 83% 0% ✔
precompiles/sr25519/src 64% 0% ➖
chain-extensions/types/xvm/src 0% 0% ❌
pallets/astar-xcm-benchmarks/src/generic 100% 0% ✔
pallets/xc-asset-config/src 64% 0% ➖
pallets/dapp-staking-v3/src/test 0% 0% ❌
pallets/dapp-staking-v3/src 91% 0% ✔
Summary 76% (4306 / 5688) 0% (0 / 0) ➖

Minimum allowed line rate is 50%

Dinonard
Dinonard approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard merged commit f39f8ef into master Apr 4, 2024
8 checks passed
@Dinonard Dinonard deleted the feat/xcm-benchamrks branch April 4, 2024 07:55
@ashutoshvarma ashutoshvarma mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

Assignees
No one assigned
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shiden related to shiden runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashutoshvarma @Dinonard